-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Remove the legacy code of AccessibilityManager #6419
Open
Seoyeon2Kim
wants to merge
1
commit into
Samsung:DevelNUI
Choose a base branch
from
Seoyeon2Kim:RemoveAccessibilityManager
base: DevelNUI
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[NUI] Remove the legacy code of AccessibilityManager #6419
Seoyeon2Kim
wants to merge
1
commit into
Samsung:DevelNUI
from
Seoyeon2Kim:RemoveAccessibilityManager
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `AccessibilityManager` hasn't been used anymore after Tizen 7.0 version. - Now, all the legacy codes of AccessibilityManager should be removed in order to prevent the confusion. - All Accessibility APIs are not public ones because they have never done ACR before, and that's why we can remove the codes like this. Signed-off-by: Seoyeon Kim <[email protected]>
Seoyeon2Kim
requested review from
hyunjushin,
dongsug-song,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
October 22, 2024 06:10
Internal API ChangedAdded: 0, Removed: 77, Changed: 0Removed- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager Tizen.NUI.Accessibility.AccessibilityManager::Instance()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Boolean Tizen.NUI.Accessibility.AccessibilityManager::GetGroupMode()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Boolean Tizen.NUI.Accessibility.AccessibilityManager::GetWrapMode()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Boolean Tizen.NUI.Accessibility.AccessibilityManager::IsFocusGroup(Tizen.NUI.BaseComponents.View)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Boolean Tizen.NUI.Accessibility.AccessibilityManager::MoveFocusBackward()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Boolean Tizen.NUI.Accessibility.AccessibilityManager::MoveFocusForward()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Boolean Tizen.NUI.Accessibility.AccessibilityManager::SetCurrentFocusView(Tizen.NUI.BaseComponents.View)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.String Tizen.NUI.Accessibility.AccessibilityManager::GetAccessibilityAttribute(Tizen.NUI.BaseComponents.View,Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.UInt32 Tizen.NUI.Accessibility.AccessibilityManager::GenerateNewFocusOrder()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.UInt32 Tizen.NUI.Accessibility.AccessibilityManager::GetCurrentFocusOrder()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.UInt32 Tizen.NUI.Accessibility.AccessibilityManager::GetFocusOrder(Tizen.NUI.BaseComponents.View)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::.ctor()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::ClearFocus()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::Dispose(System.Boolean)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::ReleaseSwigCPtr(System.Runtime.InteropServices.HandleRef)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::Reset()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::SetAccessibilityAttribute(Tizen.NUI.BaseComponents.View,Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute,System.String)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::SetFocusGroup(Tizen.NUI.BaseComponents.View,System.Boolean)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::SetFocusIndicatorView(Tizen.NUI.BaseComponents.View)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::SetFocusOrder(Tizen.NUI.BaseComponents.View,System.UInt32)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::SetGroupMode(System.Boolean)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager::SetWrapMode(System.Boolean)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager::GetCurrentFocusGroup()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager::GetCurrentFocusView()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager::GetFocusGroup(Tizen.NUI.BaseComponents.View)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager::GetFocusIndicatorView()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager::GetViewByFocusOrder(System.UInt32)
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Vector2 Tizen.NUI.Accessibility.AccessibilityManager::GetReadPosition()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.EventHandler`1<Tizen.NUI.Accessibility.AccessibilityManager/FocusChangedEventArgs> Tizen.NUI.Accessibility.AccessibilityManager::FocusChanged
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.EventHandler`1<Tizen.NUI.Accessibility.AccessibilityManager/FocusedViewActivatedEventArgs> Tizen.NUI.Accessibility.AccessibilityManager::FocusedViewActivated
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.EventHandler`1<Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotEventArgs> Tizen.NUI.Accessibility.AccessibilityManager::FocusOvershot
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionActivate
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionBack
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionClearFocus
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionDown
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionMoveToFirst
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionMoveToLast
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionNext
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionOver
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionPageDown
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionPageLeft
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionPageRight
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionPageUp
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionPrevious
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionRead
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionReadFromNext
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionReadFromTop
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionReadNext
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionReadPauseResume
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionReadPrevious
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionScrollDown
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionScrollUp
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionStartStop
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionUp
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::ActionZoom
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.ReturnTypeEventHandler`3<System.Object,System.EventArgs,System.Boolean> Tizen.NUI.Accessibility.AccessibilityManager::StatusChanged
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute::AttributeNumber
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute::Hint
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute::Label
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute::Trait
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute Tizen.NUI.Accessibility.AccessibilityManager/AccessibilityAttribute::Value
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager/FocusChangedEventArgs
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager/FocusChangedEventArgs::ViewCurrent()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager/FocusChangedEventArgs::ViewNext()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager/FocusChangedEventArgs::.ctor()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager/FocusedViewActivatedEventArgs
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager/FocusedViewActivatedEventArgs::View()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager/FocusedViewActivatedEventArgs::.ctor()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotDirection
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotDirection Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotDirection::Next
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotDirection Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotDirection::Previous
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotEventArgs
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotDirection Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotEventArgs::FocusOvershotDirection()
- /// <since_tizen>6</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotEventArgs::CurrentFocusedView()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Accessibility.AccessibilityManager/FocusOvershotEventArgs::.ctor()
|
youngsuns
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -1810,17 +1807,6 @@ internal void BaseRemove(View view) | |||
base.Remove(view); | |||
} | |||
|
|||
internal override bool OnAccessibilityPan(PanGesture gestures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ. PanGesture 관련해서 현재 쓰이는 코드는 어떤건가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
AccessibilityManager
hasn't been used anymore after Tizen 7.0 version.API Changes
AccessibilityManager
class